Add possibility to hook into modelgen plugin #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! |
|
Very useful feature for bson, mapstructure, camel to under score... |
vektah
reviewed
Oct 28, 2019
|
This needs some docs before we can |
This change introduces option to implement custom hook for model generation plugin without the need to completly copy the whole `modelgen` plugin. One very possible case is as described in #876 and with this change the solution for that can be: ```golang func mutateHook(b *ModelBuild) *ModelBuild { for _, model := range b.Models { for _, field := range model.Fields { field.Tag += ` orm_binding:"` + model.Name + `.` + field.Name + `"` } } return b } ... func main() { p := modelgen.Plugin { MutateHook: mutateHook, } ... } ```
|
Those docs look great, thanks! |
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Add possibility to hook into modelgen plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize there already is a branch modelgen-structtags for the mentioned issue and for what this change tries to accomplish. I'm opening a PR nonetheless at least as a suggestion since the feature has more general implications (possibility to mutate the whole generated models before rendering). Feel free to close this if the mentioned branch is close to solving the issue.
This change introduces option to implement custom hook for model
generation plugin without the need to completly copy the whole
modelgenplugin.One very possible case is as described in #876 and with this change the solution for
that can be:
I have: